Skip to content
This repository was archived by the owner on Nov 17, 2020. It is now read-only.

Conversation

dcorbacho
Copy link
Contributor

I can't think of a reason why we won't show the last 8/24h for message rates when they're available - same as message counters - instead of default to basic.

Also removes warning from the console, when we can easily set the default for all the known rates.

[#165377789]

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit ca89c36 into master Apr 25, 2019
@michaelklishin michaelklishin deleted the overview-rates branch April 25, 2019 02:20
michaelklishin added a commit that referenced this pull request Apr 25, 2019
Set msg rates in overview to global and basic in queue pages

(cherry picked from commit ca89c36)
@michaelklishin
Copy link
Contributor

Backported to v3.7.x.

@michaelklishin michaelklishin added this to the 3.7.15 milestone Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants