Skip to content
This repository was archived by the owner on Nov 17, 2020. It is now read-only.

Don't report progress via continuous 102 Processing responses #718

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Don't report progress via continuous 102 Processing responses #718

merged 2 commits into from
Jul 16, 2019

Conversation

michaelklishin
Copy link
Contributor

Proposed Changes

Don't report defs import progress using 102 Processing.

It is problematic for some client libraries, as demonstrated in #715 (72734eb).

So this undoes a part of #711 but keeps the timeout disabled on the
HTTP API end.

Per discussion with @acogoluegnes.

Types of Changes

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

See #711, #715 for background.

@michaelklishin
Don't report defs import progress using 102 Processing
4ec13f0 
It is problematic for some client libraries, as demonstrated
in #715 (72734eb).

So this undoes a part of #711 but keeps the timeout disabled on the
HTTP API end.

Per discussion with @acogoluegnes.

References #711, #715.
@michaelklishin
Update exports and tests for 4ec13f0
41055d2 
References #711, #715.
lukebakken
lukebakken approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a nice idea while it lasted...

@michaelklishin michaelklishin merged commit 0283e05 into master Jul 16, 2019
@michaelklishin michaelklishin deleted the rabbitmq-management-711-part-two branch July 16, 2019 19:48
michaelklishin added a commit that referenced this pull request Jul 16, 2019
@michaelklishin
Merge pull request #718 from rabbitmq/rabbitmq-management-711-part-two
6363265 
Don't report progress via continuous 102 Processing responses

(cherry picked from commit 0283e05)
@michaelklishin
Copy link
Contributor Author

Backported to v3.7.x.

@michaelklishin michaelklishin added this to the 3.7.17 milestone Jul 16, 2019
@michaelklishin michaelklishin mentioned this pull request Jul 16, 2019
Closed
acogoluegnes
acogoluegnes reviewed Jul 17, 2019
View reviewed changes
Copy link
Contributor

@acogoluegnes acogoluegnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@acogoluegnes acogoluegnes acogoluegnes left review comments

@lukebakken lukebakken lukebakken approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.17
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelklishin @acogoluegnes @lukebakken