Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster wide queue limit - main #11212

Merged
merged 2 commits into from
May 22, 2024

Conversation

SimonUnge
Copy link
Member

Proposed Changes

Same as #11196 but for main branch.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

@mergify mergify bot added the bazel label May 10, 2024
@SimonUnge SimonUnge force-pushed the cluster_wide_queue_limit_main branch 2 times, most recently from c934103 to 39d1376 Compare May 10, 2024 17:17
@SimonUnge
Copy link
Member Author

Will rebase on #11222 once merged, to combine the logic a bit.

@michaelklishin
Copy link
Member

michaelklishin commented May 21, 2024

@SimonUnge I have rebased this PR on top of main, please take a look. There was a conflict to resolve.

@SimonUnge SimonUnge force-pushed the cluster_wide_queue_limit_main branch from c0cb080 to 60ae6c0 Compare May 21, 2024 17:42
@SimonUnge
Copy link
Member Author

@SimonUnge I have rebased this PR on top of main, please take a look. There was a conflict to resolve.

@michaelklishin Thanks, I fixed it up!

@SimonUnge
Copy link
Member Author

@SimonUnge I have rebased this PR on top of main, please take a look. There was a conflict to resolve.

@michaelklishin Thanks, I fixed it up!

well, something is broker, looking into it...

@SimonUnge
Copy link
Member Author

@SimonUnge I have rebased this PR on top of main, please take a look. There was a conflict to resolve.

@michaelklishin Thanks, I fixed it up!

well, something is broker, looking into it...

@michaelklishin ok now it looks good.

@michaelklishin michaelklishin merged commit 7d64d3d into rabbitmq:main May 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants