Policy validation could let invalid values in #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any other value will break the validation cycle and leave the rest of the arguments without validate [#165689664]
lukebakken
reviewed
May 2, 2019
| validate_policy(KeyList) -> | ||
| case proplists:lookup(<<"queue-master-locator">> , KeyList) of | ||
| {_, Strategy} -> validate_strategy(Strategy); | ||
| {_, Strategy} -> case validate_strategy(Strategy) of |
There was a problem hiding this comment.
I must be missing something, but I don't see how validate_strategy/1 can return anything other than {ok, _} or {error, "~p invalid queue-master-locator value", [Strategy]}
There was a problem hiding this comment.
validate_policy/1 should return either ok or {error, term()}, but not {ok, term()}. https://github.com/rabbitmq/rabbitmq-server/blob/master/src/rabbit_policy.erl#L528
hairyhum
approved these changes
May 2, 2019
michaelklishin
approved these changes
May 2, 2019
[#165689664]
|
@hairyhum Test just added |
michaelklishin
approved these changes
May 2, 2019
michaelklishin
added a commit
that referenced
this pull request
May 3, 2019
Policy validation must return 'ok' or an error (cherry picked from commit 3cfcacb)
|
Backported to |
michaelklishin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any other value will break the validation cycle and leave the rest of the arguments without validate
Reported in the mailing list: https://groups.google.com/forum/#!topic/rabbitmq-users/7mwL2AWwUyI
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.