Skip to content

Upgrade bundled Cuttlefish to 2.3.0 produced on Erlang/OTP 20.3 #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2019
Merged

Upgrade bundled Cuttlefish to 2.3.0 produced on Erlang/OTP 20.3 #2073

merged 2 commits into from
Aug 8, 2019

Conversation

michaelklishin
Copy link
Collaborator

@michaelklishin michaelklishin commented Aug 7, 2019 •
edited
Loading

Proposed Changes

This is #2072 for v3.7.x.

The currently bundled version is about 3 years old and spits (cosmetic) exceptions on startup on Erlang/OTP 22.
This version was built on Erlang 20.3.

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin added this to the 3.7.18 milestone Aug 7, 2019
@michaelklishin michaelklishin changed the title Bundle Cuttlefish escript produced on Erlang/OTP 20.3 Bundle Cuttlefish 2.3.0 escript produced on Erlang/OTP 20.3 Aug 8, 2019
@michaelklishin michaelklishin changed the title Bundle Cuttlefish 2.3.0 escript produced on Erlang/OTP 20.3 Upgrade bundled Cuttlefish to 2.3.0 produced on Erlang/OTP 20.3 Aug 8, 2019
dumbbell
dumbbell requested changes Aug 8, 2019
View reviewed changes
Copy link
Collaborator

@dumbbell dumbbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please specify the version of Cuttlefish in the commit message?

@michaelklishin michaelklishin force-pushed the mk-cuttlefish-upgrade-v3.7.x branch from ab36740 to 26fea7e Compare August 8, 2019 08:40
@michaelklishin
Copy link
Collaborator Author

Done.

@michaelklishin michaelklishin merged commit 77d730c into v3.7.x Aug 8, 2019
@michaelklishin michaelklishin deleted the mk-cuttlefish-upgrade-v3.7.x branch August 8, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumbbell dumbbell dumbbell approved these changes

@lukebakken lukebakken Awaiting requested review from lukebakken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.18
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelklishin @dumbbell