Skip to content

After network partition some classic queues are crashed, do not have mirrors #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2020
Merged

After network partition some classic queues are crashed, do not have mirrors #2273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/rabbit_mirror_queue_misc.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,21 @@ add_mirror(QName, MirrorNode, SyncMode) ->
#resource{virtual_host = VHost} = amqqueue:get_name(Q),
case rabbit_vhost_sup_sup:get_vhost_sup(VHost, MirrorNode) of
{ok, _} ->
SPid = rabbit_amqqueue_sup_sup:start_queue_process(
try
SPid = rabbit_amqqueue_sup_sup:start_queue_process(
MirrorNode, Q, slave),
log_info(QName, "Adding mirror on node ~p: ~p~n",
log_info(QName, "Adding mirror on node ~p: ~p~n",
[MirrorNode, SPid]),
rabbit_mirror_queue_slave:go(SPid, SyncMode);
rabbit_mirror_queue_slave:go(SPid, SyncMode)
of
_ -> ok
catch
error:QError ->
log_warning(QName,
"Unable to start queue mirror on node '~p'. "
"Target queue supervisor is not running: ~p~n",
[MirrorNode, QError])
end;
{error, Error} ->
log_warning(QName,
"Unable to start queue mirror on node '~p'. "
Expand Down