[RA OCF HA] Ignore stderr when calling rabbitmqctl eval() #3524
Conversation
In newer Erlang, beam.smp no longer writes a pidfile, until the rabbit applicataion starts. It also no longer passes -mneisa dir and -sname, which are required in order to start the node only delaying the application start up. Handle that so the Pacemaker HA setup keeps working with newer Erlang and rabbitmq-server versions. Fix '[ x == x ]' bashisms as well to silence errors in the RA logs. Signed-off-by: Bogdan Dobrelya <bogdando@mail.ru>
Signed-off-by: Bogdan Dobrelya <bogdando@mail.ru>
Every time we recompile the erlang/elixir/rebar/rabbitmq stack there is one or more fresh new warnings that will completely trip up any parsing of these commands. Most end up being bugs that get fixed later on [1]. Since stderr is rarely interesting and just holds any rebase up, let's ignore it when running these rabbitmqctl commands. [1] https://elixirforum.com/t/mix-local-hex-warning-authenticity-is-not-established-by-certificate-path-validation/39665 Authored-by: Michele Baldessari <michele@acksyn.org> Signed-off-by: Bogdan Dobrelya <bogdando@mail.ru>
|
@mbaldessari PTAL |
|
Our team would prefer to not add any more CI services, both for practical and company policy reasons. Would it be possible to remove the CircleCI integration bits? |
|
@bogdando in fact, our team is leaning towards not having this OCF script in our repo at all. Would the OpenStack community look into finding a new home for it? For example, the script is not even tested against the latest RabbitMQ version, so why do we have it in our repo in this day and age? |
|
I tested it and it worked well |
|
sorry, I actually confused the patches in this PR :) |
Got it @michaelklishin , thank you for the info! |
Proposed Changes
Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
A pull request that doesn't explain why the change was made has a much lower chance of being accepted.
If English isn't your first language, don't worry about it and try to communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.