Limit number of unique node names for rabbitmqctl #552
Conversation
It prevents atom table overflow in a long running broker. Fixes rabbitmq#549
There was a problem hiding this comment.
rabbit_misc:random is undefined.
random:uniform can be used in this case, because it just retries in same process.
There was a problem hiding this comment.
Yeah, you'll need rabbitmq/rabbitmq-common#48
And also you can't simply run ./scripts/rabbitmqctl from rabbitmq-server checkout - rabbit_common will be missing from code path (but on installed server it will be available through rabbit_common.ez archive).
There was a problem hiding this comment.
One can run make package-generic-unix UNOFFICIAL_RELEASE=true from the umbrella to produce a tarball. It should take a couple of minutes.
There was a problem hiding this comment.
Then every sequence of "random" numbers will be the same - and it's exactly the thing that we want to avoid, to reduce contention.
Limit number of unique node names for rabbitmqctl
This will limit the number of CLI node names to 1024 by taking the current epoch seconds modulo a random number between 1 and 1024. Follow-up to the following: rabbitmq/rabbitmq-server#552 https://groups.google.com/d/msg/rabbitmq-users/aSnlC5hSvMk/sIWtv5fxCgAJ
This will limit the number of CLI node names to 1024 by taking the current epoch seconds modulo a random number between 1 and 1024. Follow-up to the following: rabbitmq/rabbitmq-server#552 https://groups.google.com/d/msg/rabbitmq-users/aSnlC5hSvMk/sIWtv5fxCgAJ
3 participants
It prevents atom table overflow in a long running broker.
Fixes #549