Skip to content

Don't run testcases in parallel when using Bazel #8944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Don't run testcases in parallel when using Bazel #8944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions deps/rabbit/test/feature_flags_v2_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,29 @@ all() ->
].

groups() ->
%% Don't run testcases in parallel when Bazel is used because they fail
%% with various system errors in CI, like the inability to spawn system
%% processes or to open a TCP port.
UsesBazel = case os:getenv("RABBITMQ_RUN") of
false -> false;
_ -> true
end,
GroupOptions = case UsesBazel of
false -> [parallel];
true -> []
end,
Groups =
[
{direct, [parallel],
{direct, GroupOptions,
[
rpc_calls
]},
{cluster_size_1, [parallel],
{cluster_size_1, GroupOptions,
[
enable_unknown_feature_flag_on_a_single_node,
enable_supported_feature_flag_on_a_single_node
]},
{cluster_size_3, [parallel],
{cluster_size_3, GroupOptions,
[
enable_unknown_feature_flag_in_a_3node_cluster,
enable_supported_feature_flag_in_a_3node_cluster,
Expand Down
27 changes: 19 additions & 8 deletions deps/rabbit/test/queue_parallel_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,17 @@ all() ->
].

groups() ->
%% Don't run testcases in parallel when Bazel is used because they fail
%% with various system errors in CI, like the inability to spawn system
%% processes or to open a TCP port.
UsesBazel = case os:getenv("RABBITMQ_RUN") of
false -> false;
_ -> true
end,
GroupOptions = case UsesBazel of
false -> [parallel];
true -> []
end,
AllTests = [publish,
consume,
consume_first_empty,
Expand Down Expand Up @@ -56,14 +67,14 @@ groups() ->
],
[
{parallel_tests, [], [
{classic_queue, [parallel], AllTests ++ [delete_immediately_by_pid_succeeds,
trigger_message_store_compaction]},
{mirrored_queue, [parallel], AllTests ++ [delete_immediately_by_pid_succeeds,
trigger_message_store_compaction]},
{quorum_queue, [parallel], AllTests ++ ExtraBccTests ++ [delete_immediately_by_pid_fails]},
{quorum_queue_in_memory_limit, [parallel], AllTests ++ [delete_immediately_by_pid_fails]},
{quorum_queue_in_memory_bytes, [parallel], AllTests ++ [delete_immediately_by_pid_fails]},
{stream_queue, [parallel], ExtraBccTests ++ [publish, subscribe]}
{classic_queue, GroupOptions, AllTests ++ [delete_immediately_by_pid_succeeds,
trigger_message_store_compaction]},
{mirrored_queue, GroupOptions, AllTests ++ [delete_immediately_by_pid_succeeds,
trigger_message_store_compaction]},
{quorum_queue, GroupOptions, AllTests ++ ExtraBccTests ++ [delete_immediately_by_pid_fails]},
{quorum_queue_in_memory_limit, GroupOptions, AllTests ++ [delete_immediately_by_pid_fails]},
{quorum_queue_in_memory_bytes, GroupOptions, AllTests ++ [delete_immediately_by_pid_fails]},
{stream_queue, GroupOptions, ExtraBccTests ++ [publish, subscribe]}
]}
].

Expand Down