Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue, #9059, occurs when the ldap plugin submits a query to retrieve an LDAP attribute and that attribute has a non-ascii character such as ß. When the plugin receives a binary representation of a string with a non-ascii character, it treated as a list of strings when it was a list of characters. It tried to join those characters with
string:join
function. When this function encounter the non-ascii characters, it failed to concatenate it and threw the exceptionbadarg
.Proposed Changes
Use list comprehensions instead of string:join to produce a string representation of the attribute's value which can be a single string -with only ascii characters or mix of ascii and non-ascii- or multiple strings.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply