CQ: Fix a crash when CMQ master changes in mixed environment test #9507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When policies are applied to change a CMQ master, and that master moves from 3.13 to 3.12, this triggers a CQ version change (because it defaults to v2 in 3.13 but v1 in 3.12). which leads to a crash because the files on disk have an index entry for messages that are in memory only. The index entry is only created with CMQs, normal CQs prohibit this behavior. Since we are going to remove CMQs "soon" the solution to fix the crash was to simply ignore the index entry when we know the message is already in memory.
HoloRin
added a commit
that referenced
this pull request
Sep 21, 2023
CQ: Fix a crash when CMQ master changes in mixed environment test (backport #9507)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When policies are applied to change a CMQ master, and that master moves from 3.13 to 3.12, this triggers a CQ version change (because it defaults to v2 in 3.13 but v1 in 3.12). which leads to a crash because the files on disk have an index entry for messages that are in memory only.
The index entry is only created with CMQs, normal CQs prohibit this behavior. Since we are going to remove CMQs "soon" the solution to fix the crash was to simply ignore the index entry when we know the message is already in memory.
This will need to be merged to both main and 3.12 before this fixes the mixed test that currently fails.
Types of Changes