Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call #9550

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

dcorbacho
Copy link
Contributor

@dcorbacho dcorbacho commented Sep 27, 2023

A direct client operation fails if the queue is exclusive. This API should behave like the rabbitmqctl that can delete the queue even in that case

Types of Changes

  • Bug fix (non-breaking change which fixes issue HTTP API: DELETE /api/queues/{vhost}/{name} should use an internal API call #8758 )
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

@dcorbacho dcorbacho added this to the 3.13.0 milestone Sep 27, 2023
@dcorbacho dcorbacho self-assigned this Sep 27, 2023
A direct client operation fails if the queue is exclusive. This
API should behave like the rabbitmqctl that can delete the queue
even in that case
@michaelklishin michaelklishin merged commit 13702b7 into main Sep 27, 2023
13 checks passed
@michaelklishin michaelklishin deleted the issue-8758 branch September 27, 2023 06:55
michaelklishin added a commit that referenced this pull request Sep 27, 2023
HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call (backport #9550)
michaelklishin added a commit that referenced this pull request Sep 27, 2023
HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call (backport #9550) (backport #9551)
michaelklishin added a commit that referenced this pull request Dec 7, 2023
michaelklishin added a commit that referenced this pull request Dec 20, 2023
michaelklishin added a commit that referenced this pull request Dec 20, 2023
michaelklishin added a commit that referenced this pull request Dec 20, 2023
michaelklishin added a commit that referenced this pull request Dec 20, 2023
michaelklishin added a commit that referenced this pull request Dec 20, 2023
michaelklishin added a commit that referenced this pull request Dec 20, 2023
@michaelklishin
Copy link
Member

FYI, this PR is about to be reverted.

Replacing direct client's authorization checks ended up being not worth the gain in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants