-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call #9550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
requested changes
Sep 27, 2023
A direct client operation fails if the queue is exclusive. This API should behave like the rabbitmqctl that can delete the queue even in that case
dcorbacho
force-pushed
the
issue-8758
branch
from
September 27, 2023 06:19
8121d55
to
78f901a
Compare
michaelklishin
approved these changes
Sep 27, 2023
michaelklishin
added a commit
that referenced
this pull request
Sep 27, 2023
HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call (backport #9550)
12 tasks
michaelklishin
added a commit
that referenced
this pull request
Dec 7, 2023
michaelklishin
added a commit
that referenced
this pull request
Dec 20, 2023
michaelklishin
added a commit
that referenced
this pull request
Dec 20, 2023
michaelklishin
added a commit
that referenced
this pull request
Dec 20, 2023
michaelklishin
added a commit
that referenced
this pull request
Dec 20, 2023
michaelklishin
added a commit
that referenced
this pull request
Dec 20, 2023
michaelklishin
added a commit
that referenced
this pull request
Dec 20, 2023
This was referenced Dec 20, 2023
Closed
FYI, this PR is about to be reverted. Replacing direct client's authorization checks ended up being not worth the gain in this PR. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A direct client operation fails if the queue is exclusive. This API should behave like the rabbitmqctl that can delete the queue even in that case
Types of Changes
Checklist
CONTRIBUTING.md
document