Fix a file descriptor leak in an aux command handler #9790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handle_aux clause for `oldest_entry_timestamp` did not return the updated Log structure and thus ends up leaking file descriptors when this function is called and the segment isn't already open.
michaelklishin
approved these changes
Oct 26, 2023
michaelklishin
changed the title
michaelklishin
added a commit
that referenced
this pull request
Oct 27, 2023
Fix a file descriptor leak in an aux command handler (backport #9790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handle_aux clause for
oldest_entry_timestampdid not return the updated Log structure and thus ends up leaking file descriptors when this function is called and the segment isn't already open.Note that this issue does not affect the absolute majority of RabbitMQ installations.