Skip to content

Conversation

ricardSiliuk
Copy link
Contributor

Enrich SocketException in Connection.cs by reporting the actual ip/host + port where connection was made for easier investigating.

Try to connect to all nodes in a random order when creating a consumer in case some nodes misbehave. Handle the case when none of them do.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #124 (91380c1) into main (7eda011) will increase coverage by 0.52%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   91.27%   91.79%   +0.52%     
==========================================
  Files          75       75              
  Lines        5637     5668      +31     
  Branches      347      349       +2     
==========================================
+ Hits         5145     5203      +58     
+ Misses        406      383      -23     
+ Partials       86       82       -4     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/Connection.cs 89.16% <61.53%> (-3.43%) ⬇️
RabbitMQ.Stream.Client/RoutingClient.cs 100.00% <100.00%> (+4.54%) ⬆️
Tests/UnitTests.cs 98.02% <100.00%> (+5.80%) ⬆️
RabbitMQ.Stream.Client/Client.cs 91.50% <0.00%> (+0.28%) ⬆️
Tests/ClientTests.cs 97.29% <0.00%> (+1.35%) ⬆️
RabbitMQ.Stream.Client/LogEventSource.cs 95.34% <0.00%> (+2.32%) ⬆️
...abbitMQ.Stream.Client/Reliable/ReliableProducer.cs 91.03% <0.00%> (+4.13%) ⬆️
RabbitMQ.Stream.Client/WireFormatting.cs 74.82% <0.00%> (+4.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eda011...91380c1. Read the comment docs.

Gsantomaggio
Gsantomaggio previously approved these changes May 23, 2022
Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukebakken Looks good to me

@lukebakken lukebakken force-pushed the ricsi-issue-123-socket-conn-resiliency branch from d4c506a to 91380c1 Compare May 23, 2022 22:01
@lukebakken lukebakken added this to the 1.0.0-rc.2 milestone May 23, 2022
@lukebakken lukebakken self-assigned this May 23, 2022
@lukebakken lukebakken merged commit 62217de into rabbitmq:main May 23, 2022
@lukebakken
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants