-
Notifications
You must be signed in to change notification settings - Fork 49
Add exceptions to events #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Scratch that, it doesn't do what I want it to do :D I'll come back to this later. I still want to have the exception itself in event payload... |
Ok, should be good now. If necessary, I can add tests for both |
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 91.61% 91.80% +0.18%
==========================================
Files 75 75
Lines 5668 5744 +76
Branches 349 354 +5
==========================================
+ Hits 5193 5273 +80
+ Misses 388 386 -2
+ Partials 87 85 -2
Continue to review full report at Codecov.
|
Write log events to stdout/stderr as appropriate. Add code to view logged messages when running tests
@ricsiLT thanks for your contribution. I made some changes to ensure that inner exceptions are taken into account, as well as enabling logging to console when the tests are run so the output can be verified. Let me know what you think. |
LGTM :D |
Thank you @ricsiLT ! |
Add exception objects to events so you can inspect them in event listeners