Skip to content

Conversation

lukebakken
Copy link
Contributor

Fixes #72

@lukebakken lukebakken added this to the v1.0.0-beta.4 milestone Feb 17, 2022
@lukebakken lukebakken self-assigned this Feb 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #78 (96e0cee) into main (89390aa) will decrease coverage by 0.25%.
The diff coverage is 92.37%.

❗ Current head 96e0cee differs from pull request most recent head 988ea93. Consider uploading reports for the commit 988ea93 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   90.73%   90.48%   -0.26%     
==========================================
  Files          66       66              
  Lines        4415     4446      +31     
  Branches      261      261              
==========================================
+ Hits         4006     4023      +17     
- Misses        348      365      +17     
+ Partials       61       58       -3     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/AMQP/AmqpParseException.cs 100.00% <ø> (ø)
RabbitMQ.Stream.Client/AMQP/Annotations.cs 100.00% <ø> (ø)
...bbitMQ.Stream.Client/AMQP/ApplicationProperties.cs 100.00% <ø> (ø)
RabbitMQ.Stream.Client/AddressResolver.cs 100.00% <ø> (ø)
RabbitMQ.Stream.Client/DeletePublisherResponse.cs 82.35% <ø> (ø)
RabbitMQ.Stream.Client/SslOption.cs 54.83% <0.00%> (ø)
Tests/ApiApproval.cs 14.28% <0.00%> (ø)
Tests/PermissionTests.cs 100.00% <ø> (ø)
RabbitMQ.Stream.Client/AMQP/Header.cs 86.20% <66.66%> (ø)
RabbitMQ.Stream.Client/ClientExceptions.cs 61.29% <66.66%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89390aa...988ea93. Read the comment docs.

@lukebakken lukebakken marked this pull request as ready for review February 17, 2022 23:28
Formatted code using the .editorconfig from here - https://github.com/dotnet/format/blob/main/.editorconfig

Same license as rabbitmq/rabbitmq-dotnet-client

Add style verification to build. Address style issues
@lukebakken lukebakken force-pushed the rabbitmq-stream-dotnet-client-72 branch from 988ea93 to 1679abb Compare February 17, 2022 23:28
@Gsantomaggio Gsantomaggio merged commit 9bd4c9c into main Feb 18, 2022
@Gsantomaggio Gsantomaggio deleted the rabbitmq-stream-dotnet-client-72 branch February 18, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the "dotnet format" command
3 participants