Skip to content

Conversation

Gsantomaggio
Copy link
Member

Fixes #81

@Gsantomaggio Gsantomaggio marked this pull request as draft March 4, 2022 15:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #82 (891c7eb) into main (850db94) will increase coverage by 0.00%.
The diff coverage is 97.82%.

❗ Current head 891c7eb differs from pull request most recent head 12f3b07. Consider uploading reports for the commit 12f3b07 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files          69       69           
  Lines        4502     4535   +33     
  Branches      262      265    +3     
=======================================
+ Hits         4087     4117   +30     
  Misses        358      358           
- Partials       57       60    +3     
Impacted Files Coverage Δ
Tests/ProducerSystemTests.cs 99.26% <97.82%> (-0.74%) ⬇️
RabbitMQ.Stream.Client/Subscribe.cs 63.73% <0.00%> (-1.10%) ⬇️
RabbitMQ.Stream.Client/MetaData.cs 90.65% <0.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850db94...12f3b07. Read the comment docs.

@Gsantomaggio Gsantomaggio marked this pull request as ready for review March 4, 2022 15:35
@Gsantomaggio Gsantomaggio requested a review from lukebakken March 4, 2022 15:37
@lukebakken lukebakken merged commit 90a740d into main Mar 4, 2022
@lukebakken lukebakken deleted the refactor_test branch March 4, 2022 15:39
@lukebakken lukebakken added this to the v1.0.0-beta.5 milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProducerMixingDifferentConfirmations test fails on gitub action
3 participants