-
Notifications
You must be signed in to change notification settings - Fork 49
Change the way to decide when the client socket is open #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@simone-fariselli you may be interested in this PR. |
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 91.39% 91.44% +0.04%
==========================================
Files 69 69
Lines 4696 4743 +47
Branches 272 276 +4
==========================================
+ Hits 4292 4337 +45
- Misses 343 345 +2
Partials 61 61
Continue to review full report at Codecov.
|
I'm investigating this failure:
|
128c334
to
818552a
Compare
When the tcp connection is forced the client sets the status as closed. Make IsClosed setter private and only set in the Client ctor Remove limitations on test parallelism, add IsClosed to Connection
818552a
to
f63d30d
Compare
When the tcp connection is forced the client sets the status as closed.
Fixes: #97
See the comment on #97 (comment) or the test
CloseProducerConsumerAfterForceCloseShouldNotRaiseError
to reproduce the error.