Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging fixes #70

Closed
wants to merge 1 commit into from
Closed

Packaging fixes #70

wants to merge 1 commit into from

Conversation

purcell
Copy link

@purcell purcell commented Nov 5, 2016

  • Remove redundant "Emacs package" description portion, and replace with a more descriptive phrase
  • Add "languages" to keywords

- Remove redundant "Emacs package" description portion, and replace with a more descriptive phrase
- Add "languages" to keywords
@coveralls
Copy link

coveralls commented Nov 5, 2016

Coverage Status

Coverage remained the same at 64.535% when pulling 76282be on purcell:patch-1 into 2975da2 on racer-rust:master.

@Wilfred
Copy link
Member

Wilfred commented Nov 5, 2016

Thanks.

I don't think your new package summary quite summarises what this package does. racer.el is not just completion: it supports going to definition, eldoc, and rendering help from rustdoc markdown docstrings.

I added 'official' to distinguish from the ac-racer and company-racer packages. The repos in the racer-rust GitHub organisation are official and the racer core devs contribute to them.

Other glue packages include 'A Git porcelain inside Emacs', 'Emacs integration for gist.github.com', 'Emacs interface to Google Translate.' on melpa.org. What do you think would be a better summary?

@purcell
Copy link
Author

purcell commented Nov 5, 2016

I don't think your new package summary quite summarises what this package does. racer.el is not just completion: it supports going to definition, eldoc, and rendering help from rustdoc markdown docstrings.

Oh, I copied it from the docstring of the custom group, so maybe that needs fixing too.

I don't care too much, but mention of Emacs in the description of an elisp package is always redundant, and those other examples you found would ideally get fixed up too.

Wilfred added a commit that referenced this pull request Nov 13, 2016
Mentioning Emacs is redundant, and we might as well give a better
summary of the features offered.

See PR #70.
@Wilfred
Copy link
Member

Wilfred commented Nov 13, 2016

Oh, I copied it from the docstring of the custom group, so maybe that needs fixing too.

Thanks, I hadn't spotted that.

This should now be fixed in ca5b2f2 -- does that look better to you?

@purcell
Copy link
Author

purcell commented Nov 13, 2016

Yep, great!

@purcell purcell closed this Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants