Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rustc-ap* to v679 #1132

Merged
merged 2 commits into from
Oct 3, 2020
Merged

Conversation

calebcartwright
Copy link
Contributor

We're planning to release a new version of rustfmt that also includes a bump of the rustc-ap-* crates to v679, so opening this to keep things synchronized

@calebcartwright
Copy link
Contributor Author

Will bump the toolchain as well

@dtolnay
Copy link

dtolnay commented Oct 1, 2020

Windows CI failed (https://ci.appveyor.com/project/TedDriggs/racer-xr5g5/builds/35374255/job/2ygcxfq0t9ds2cqg), but it appears the same tests are failing the same way on master too right now (https://ci.appveyor.com/project/TedDriggs/racer-xr5g5/branch/master/job/jl8rg68a5aai9971), so unrelated to this PR.

@calebcartwright
Copy link
Contributor Author

so unrelated to this PR.

Correct. @Xanewok got the tests passing again not too long ago but seems to be a caching issue on Appveyor (refs #1130 (comment))

Copy link
Collaborator

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for my delay!

@kngwyu kngwyu merged commit b1614b0 into racer-rust:master Oct 3, 2020
@calebcartwright
Copy link
Contributor Author

No worries, and thank you!

@calebcartwright calebcartwright deleted the rustc-ap-bump branch October 3, 2020 15:26
@kngwyu
Copy link
Collaborator

kngwyu commented Oct 4, 2020

Released 2.1.39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants