More helpful error when rust-src is missing #797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this changes the behavior when "rustc --print sysroot" returns a value. Before the change, if this command was successful, but the expected paths not found in the yielded root, it would fallback on looking for the dir in "/usr/...". I think this makes sense, if rustc is present and functional, it should use its sysroot or fail. Otherwise, things are potentially inconsistent. Also makes the following changes: * Fixes environment variable name in description() * Fixes double use of " around paths, display for PathBuf already includes quotes.
|
This is showing all tests failing; is it dependent on another commit, or is it a WIP? |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this changes the behavior when "rustc --print sysroot" returns a
value. Before the change, if this command was successful, but the expected paths
not found in the yielded root, it would fallback on looking for the dir in
"/usr/...". I think this makes sense, if rustc is present and functional, it
should use its sysroot or fail. Otherwise, things are potentially inconsistent.
Also makes the following changes:
Fixes environment variable name in description()
Fixes double use of " around paths, display for PathBuf already includes
quotes.
Note I am new to rust, so this change should probably be scrutinized carefully. I did test it out, of course, it seems to work well.