Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to put kube-ovn-controller pods in a central c… #265

Merged
merged 1 commit into from
May 24, 2024

Conversation

awfabian-rs
Copy link
Contributor

…luster location.

JIRA:OSPC-393

@awfabian-rs awfabian-rs marked this pull request as draft May 13, 2024 20:02
@awfabian-rs
Copy link
Contributor Author

  • kube-ovn-controller pods play a critical central role
  • I considered where to change this:
    • kustomize doesn't seem suitable
      • it would need a copy of the Deployment which has many variables with IP addresses, etc. already filled in. It just doesn't seem like it would work.
    • this doesn't seem likely to get merged to upstream kubespray and it would take some time to get through the contribution requirements
  • I tried this patch on my test cluster and ran kubespray's cluster.yml and the patch (nodeSelector on the kube-ovn-controller Deployment) stayed in place.

This seems like a logical place to put this and a logical way to centralize these and centralizing these pods seems like a good idea for Genestack, as opposed to allowing them to land on random compute and other types of nodes.

Feel free to merge if this looks good, otherwise, let me know if you have any questions, request changes, etc.

Thanks,

Adam

@awfabian-rs awfabian-rs marked this pull request as ready for review May 13, 2024 20:13
@cloudnull cloudnull merged commit d19e3ab into rackerlabs:main May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants