Quote exclusion regexes properly (#113) #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Regex-quote arbitrary files added to exclusion list * Add tests around this behaviour demonstrating regex nature * Update examples and docs to demonstrate this * Use immutable keyword parameters defaults too
jarosser06
reviewed
Nov 22, 2016
| @@ -223,6 +224,7 @@ def package(self, ignore=[]): | |||
| those files when creating the zip file. The paths to be matched are | |||
| local to the source root. | |||
| """ | |||
| ignore = ignore or [] | |||
There was a problem hiding this comment.
I don't understand why this was added in favor over setting the default for the ignore arg to [].
jarosser06
reviewed
Nov 22, 2016
| @@ -21,7 +21,8 @@ | |||
| LOG = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def copy_tree(src, dest, ignore=[], include_parent=False): | |||
| def copy_tree(src, dest, ignore=None, include_parent=False): | |||
There was a problem hiding this comment.
Again, this seems like an extra step that the default arg already covers.
jarosser06
suggested changes
Nov 22, 2016
|
Sure: mutable default arguments can often be a source bugs in Python, and some IDEs warn about their usage. This book / guide has the best explanation / example I've seen. |
jarosser06
approved these changes
Nov 22, 2016
|
I've never run into that. Thanks! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113