Use python specified as runtime in the virtualenv #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azatoth
force-pushed
the
py3venv
branch
2 times, most recently
from
5c30b4b to
1a1554a
Compare
A issue has been that even if you specify python3.6 as runtime in lambda.json, it will use python2 for the virtualenv and thus install possibly incompatible libraries (psycopg2-binary for example) This changes the behavour to use the defined "runtime" in lambda.json as basis for the virtualenv. Closes: rackerlabs#142 Relates: rackerlabs#152
jarosser06
approved these changes
Apr 26, 2018
|
Looks good thanks for the PR. |
|
@jarosser06 going to make a new release for this one? |
|
Yes. I’ll try and get it done today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A issue has been that even if you specify python3.6 as runtime in lambda.json, it will use python2 for the virtualenv and thus install possibly incompatible libraries (psycopg2-binary for example)
Closes: #142
Relates: #152