Fixed lambda-uploader to work with Python 3, using tox for testing #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarosser06
force-pushed
the
python3
branch
2 times, most recently
from
ca94e9f to
99bd7e4
Compare
This change adds the ability to run lambda-uploader in a local Python 3 environment. The lambda-uploader will explicitly look for a python2 executable instead of just using python.
|
Resolves #43 |
| dependencies: | ||
| override: | ||
| - pip install -U pip | ||
| - pip install -U tox tox-pyenv |
There was a problem hiding this comment.
Should we also include tox/tox-pyenv in test-requirements.txt or setup.py? Otherwise I have to run this installation manually when I run tests locally.
|
After discussing with @jarosser06, since this PR and work was already done before we made our new procedures yesterday, I'm going to merge it and we'll get Pylint done ASAP. |
This was referenced Apr 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to run lambda-uploader in a local Python 3
environment. The lambda-uploader will explicitly look for a python2
executable instead of just using python.