feat: PUC-529 : create provisioning network on successful deployment of neutron-server #598
Conversation
haseebsyed12
requested review from
cardoe,
mfencik,
nicholaskuechler,
skrobul and
stevekeay
haseebsyed12
force-pushed
the
puc-529_create_prov_ntw
branch
from
79995f7 to
d931f5f
Compare
haseebsyed12
changed the title
| group: apps | ||
| version: v1 | ||
| eventTypes: | ||
| - ADD |
There was a problem hiding this comment.
So is this only when the deployment is created? Can we add some descriptions / comments in these to tell the user this is how it works? We could also make this happen on update as well if we check first if the provisioning network exists?
There was a problem hiding this comment.
Added comments. sure I will add logic for UPDATE too. what I noticed was 4 jobs are executing simultaneously on UPDATE event. We need to have some lock to ensure only one job runs.
| source: | ||
| resource: | ||
| apiVersion: batch/v1 | ||
| kind: Job |
There was a problem hiding this comment.
How do we ensure only 1 job happens since it happens only on add? If we do it on update that's fine. Is there a max number of jobs that should exist? Is there a cleanup rule?
What about running this as an Argo Workflow?
There was a problem hiding this comment.
The Argo Workflow is just a question and not an ask to change things.
There was a problem hiding this comment.
yes we can use workflow too
haseebsyed12
force-pushed
the
puc-529_create_prov_ntw
branch
from
6da98e0 to
c9655ab
Compare
2 participants
No description provided.