feat(nova): build our own container with patches #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoe
force-pushed
the
nova-container
branch
6 times, most recently
from
3edb540 to
188b0e8
Compare
skrobul
reviewed
Feb 19, 2025
| # syntax=docker/dockerfile:1 | ||
|
|
||
| ARG OPENSTACK_VERSION="required_argument" | ||
| FROM docker.io/openstackhelm/nova:${OPENSTACK_VERSION}-ubuntu_jammy |
There was a problem hiding this comment.
These patches are likely quite specific to that version of the code, should we hardcode the base image here? Or just leave it and fix it when it breaks? Dunno.
There was a problem hiding this comment.
Yeah. I'd like to get to switching to building our own container from a branch we point to.
cardoe
force-pushed
the
nova-container
branch
from
188b0e8 to
c3cf09d
Compare
Add patches to fix: - ironic node validate error message log - metadata trunk_details added
mfencik
force-pushed
the
nova-container
branch
from
c3cf09d to
2a62b96
Compare
mfencik
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patches to fix: