feat: Only create SVIs for Prefixes of service_type "network:understack_svi" #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an SVI was created by the understack ml2 mech driver for every subnet created with a true value for the boolean router:external attribute. This makes it more selective, with SVIs only being created when service_type is equal to network:understack_svi. The intention here is to allow for future types of "external" network that do not require these SVIs because they have other types of router.
stevekeay
force-pushed
the
selective-svis
branch
from
0261038 to
fc23ae7
Compare
cardoe
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an SVI was created by the understack ml2 mech driver for
every subnet created with a true value for the boolean router:external
attribute.
This makes it more selective, with SVIs only being created when
service_type is equal to network:understack_svi.
The intention here is to allow for future types of "external" network
that do not require these SVIs because they have other types of router.
Closes PUC-779