Skip to content

feat: Create an OUTSIDE Network in Neutron for each new project (tenant) #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2025
Merged

feat: Create an OUTSIDE Network in Neutron for each new project (tenant) #723

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
597a0f7
Create an OUTSIDE Network in Neutron for each new project (tenant)
stevekeay Feb 25, 2025
ca7b6d3
Disable type checking around missing openstack type annotations
stevekeay Feb 25, 2025
4b2c477
Create OUTSIDE Network with rbac policy instead of router:external flag
stevekeay Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions python/understack-workflows/understack_workflows/main/sync_keystone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
_EXIT_API_ERROR = 1
_EXIT_EVENT_UNKNOWN = 2

OUTSIDE_NETWORK_NAME = "OUTSIDE"


class Event(StrEnum):
ProjectCreate = "identity.project.created"
Expand Down Expand Up @@ -70,6 +72,48 @@ def is_valid_domain(
return ret


def _create_outside_network(conn: Connection, project_id: uuid.UUID):
network = _find_outside_network(conn, project_id)
if network:
logger.info(
"%s Network %s already exists for this tenant",
OUTSIDE_NETWORK_NAME,
network.id,
)
else:
payload = {
"project_id": project_id,
"name": OUTSIDE_NETWORK_NAME,
"router:external": False,
}
network = conn.network.create_network(**payload) # type: ignore
logger.info(
"Created %s Network %s for tenant", OUTSIDE_NETWORK_NAME, network.id
)
conn.network.create_rbac_policy( # type: ignore
object_type="network",
object_id=network.id,
action="access_as_external",
target_project_id=project_id,
)


def _delete_outside_network(conn: Connection, project_id: uuid.UUID):
network = _find_outside_network(conn, project_id)
if network:
conn.delete_network(network.id)
logger.info(
"Deleted %s Network %s for this tenant", OUTSIDE_NETWORK_NAME, network.id
)


def _find_outside_network(conn, project_id):
return conn.network.find_network( # type: ignore
project_id=project_id,
name_or_id=OUTSIDE_NETWORK_NAME,
)


def handle_project_create(
conn: Connection, nautobot: Nautobot, project_id: uuid.UUID
) -> int:
Expand All @@ -80,6 +124,7 @@ def handle_project_create(
ten = ten_api.create(
id=str(project_id), name=project.name, description=project.description
)
_create_outside_network(conn, project_id)
except Exception:
logger.exception(
"Unable to create project %s / %s", str(project_id), project.name
Expand Down Expand Up @@ -113,6 +158,8 @@ def handle_project_update(
project_id,
existing_tenant.last_updated, # type: ignore
)

_create_outside_network(conn, project_id)
except Exception:
logger.exception(
"Unable to update project %s / %s", str(project_id), project.name
Expand All @@ -129,6 +176,8 @@ def handle_project_delete(
if not ten:
logger.warning("tenant %s does not exist, nothing to delete", project_id)
return _EXIT_SUCCESS

_delete_outside_network(conn, project_id)
ten.delete() # type: ignore
logger.info("deleted tenant %s", project_id)
return _EXIT_SUCCESS
Expand Down