feat: update ArgoCD AppSets to make dev/prod closer #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoe
requested review from
abhimanyu003,
ctria,
mfencik,
nicholaskuechler and
skrobul
|
@ctria @abhimanyu003 @skrobul @nicholaskuechler would definitely appreciate some feedback on the documentation changes |
cardoe
force-pushed
the
argocd-deploy-update
branch
from
9cc0e84 to
5274d56
Compare
abhimanyu003
requested changes
Apr 21, 2025
cardoe
force-pushed
the
argocd-deploy-update
branch
13 times, most recently
from
e23aef3 to
bedcf4b
Compare
|
Well I think this will work except for global. But it requires changes to the deploy repo. For global pieces it will absolutely wreck them. |
cardoe
force-pushed
the
argocd-deploy-update
branch
3 times, most recently
from
9773dbc to
c2483e5
Compare
Should we go ahead and wreck it rather sooner than later? I read the PR through but have no comments on documentation (maybe aside from fixing linter errors) |
cardoe
force-pushed
the
argocd-deploy-update
branch
4 times, most recently
from
3073118 to
08ff65b
Compare
cardoe
force-pushed
the
argocd-deploy-update
branch
from
08ff65b to
5bbe0a8
Compare
|
So the Argo kustomize patch isn't working. The etcdbackup is odd but it seems broken in the current config. The rest is a no-op. |
cardoe
force-pushed
the
argocd-deploy-update
branch
4 times, most recently
from
cb269bf to
c70b57c
Compare
cardoe
changed the title
|
Really close. The Argo Workflows patch needs the DNS zone templated in. |
cardoe
force-pushed
the
argocd-deploy-update
branch
from
31015a2 to
ae9898d
Compare
abhimanyu003
approved these changes
Jun 6, 2025
This new AppSet for the OpenStack services is a no-op with the existing AppSet to allow for a transition over without deleting resources. This AppSet follows the split of the regional and global deployments. It further supports using the same AppSet definition for production environments and development environments by using kustomize to adjust how clusters are defined.
In creating the site / global split AppSets there were a few changes in how cluster specific data can be passed down via config files in the deploy repo. This updates the operators and infra AppSet to behave the same way.
These new AppSets encompasses all the site and global services and are a no-op with the existing components AppSet to allow for transition over without deleting resources. These AppSets aims to make it easier to define the same deployment for production and development environments.
So want to use kustomize components for overriding kustomize things. Components work great and allow for URL based data fetching. However within ArgoCD authenticated URLs to components do not seem to work. That appears to be because kustomize wants URI style SSH paths while ArgoCD's repo secrets use the SSH style. Likely the best thing here would be to support cross-repo refs like the helm code does but this does not appear to be supported in upstream ArgoCD at this time. In an effort to land the updates to the deployment process this hack was made as a workaround. It should be retired and go away when components are properly handled.
These have been replaced with newer files which split the components out along the lines of site or global deployments. These are redundant now.
cardoe
force-pushed
the
argocd-deploy-update
branch
from
ceae95a to
fc7f123
Compare
ctria
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the ArgoCD AppSets to make dev and prod closer together.