Skip to content

Conversation

haseebsyed12
Copy link
Contributor

@haseebsyed12 haseebsyed12 commented May 6, 2025

copied generic ansible roles of undercloud-rackspace repo.

This ansible playbook nautobot-initial-setup.yaml is configured as nautobot helm post-upgrade hook job

@haseebsyed12 haseebsyed12 force-pushed the puc-905-nautobot-ansible branch 5 times, most recently from 0483e7d to 3fd9d54 Compare May 6, 2025 08:55
@haseebsyed12 haseebsyed12 requested a review from a team May 6, 2025 09:57
@haseebsyed12 haseebsyed12 marked this pull request as ready for review May 6, 2025 11:55
@haseebsyed12 haseebsyed12 force-pushed the puc-905-nautobot-ansible branch from 8cebe6f to f8cd760 Compare May 6, 2025 17:17
{%- set manufacturer = obj.device_type.manufacturer.name | lower -%}
{%- set serial = obj.serial | lower -%}
{%- set partition = "UC_PARTITION" | settings_or_config -%}
urn:rax:undercloud:{{ partition }}:nautobot:{{ role }}:{{ loc }}:{{ manufacturer }}-{{ serial }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't belong here. This is deployment specific.

@haseebsyed12 haseebsyed12 force-pushed the puc-905-nautobot-ansible branch 2 times, most recently from abf1dbb to c92b8af Compare May 7, 2025 14:49
@haseebsyed12 haseebsyed12 force-pushed the puc-905-nautobot-ansible branch 3 times, most recently from d571782 to eb55d70 Compare May 8, 2025 11:40
@haseebsyed12 haseebsyed12 requested review from cardoe and skrobul May 12, 2025 15:14
@haseebsyed12 haseebsyed12 force-pushed the puc-905-nautobot-ansible branch 3 times, most recently from 221ebb1 to ee56cba Compare May 13, 2025 16:31
cardoe
cardoe previously requested changes May 14, 2025
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and then one nit and I think we can land this.

@haseebsyed12 haseebsyed12 force-pushed the puc-905-nautobot-ansible branch from ee56cba to 8942758 Compare May 14, 2025 15:06
@haseebsyed12 haseebsyed12 requested a review from cardoe May 14, 2025 15:08
@haseebsyed12 haseebsyed12 force-pushed the puc-905-nautobot-ansible branch from 8942758 to d52d5e5 Compare May 15, 2025 00:21
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think you need to remove that vars directory and use a defaults directory. But otherwise this is good.

@haseebsyed12 haseebsyed12 requested a review from cardoe May 17, 2025 14:31
@haseebsyed12 haseebsyed12 enabled auto-merge May 19, 2025 09:21
@haseebsyed12 haseebsyed12 requested a review from abhimanyu003 May 19, 2025 09:22
@haseebsyed12 haseebsyed12 added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit c5af433 May 19, 2025
32 checks passed
@haseebsyed12 haseebsyed12 deleted the puc-905-nautobot-ansible branch May 19, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants