Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style the clickable “...” in the “arguments...:“ part of error messages to be more obviously clickable #390

Open
gfbee opened this issue Jun 5, 2020 · 7 comments

Comments

@gfbee
Copy link
Contributor

gfbee commented Jun 5, 2020

I have forgotten and rediscoverd this multiple times, and (some time ago) at least one person on the slack asked how to see the apparently unavailable elided arguments. Maybe we can also change it to something other than ellipsis since in non-menu contexts it doesn't suggest further interaction (and also it's not for the menu convention of meaning it will involve further interaction).

The edit just now changed the title to show the actual format “...:”. That I thought it was “:...” emphasizes the issue, since the “...” appears to say keep reading, the arguments are still to come after the “:”.

@gfbee gfbee changed the title Style the clickable “...” in “arguments:...“ to be more obviously clickable Style the clickable “...” in the “arguments...:“ part of error messages to be more obviously clickable Jun 5, 2020
@rfindler
Copy link
Member

rfindler commented Jun 5, 2020 via email

@gfbee
Copy link
Contributor Author

gfbee commented Jun 5, 2020

That seems barely more discoverable.

@rfindler
Copy link
Member

rfindler commented Jun 5, 2020

Suggestions welcome! :)

@jackfirth
Copy link
Collaborator

Making the dots blue instead of red might help? So they look like a clickable link.

@gfbee
Copy link
Contributor Author

gfbee commented Jun 5, 2020

Adding a space before the dots and moving them after the colon (or just removing the colon) would be good. Except that might interfere with any code thats been parsing the message to extract information. Although that might not be a problem if the change happens near where the actual display in DrRacket happens, in which case we can reconsider dots entirely.

@rfindler
Copy link
Member

rfindler commented Jun 5, 2020

The dots are part of the formatting rules from the error message conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants