Migrate the plot tests to use draw step files #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate the plot tests which generate plots to save and verify the draw steps using the method introduced in 05ac34e (pull request racket#62) From this migration experience, the following updates were made to the test method: * test data files are now compressed using `gzip` as some of the plots generated files larger than 10Mb * the plots are updated in-place, rather than moving them to a separate folder (named "auto"), this allows for easier inspection of a file' history (the ci.yml file was updated to upload new files from all sub-directories of the "plot-test" package) * the test run in ci.yml now runs all the files, even if they don't have a test module -- some of the plot tests already used rackunit, but the tests were not in a seprate submodule, these tests are now running in Github Actions (they were already running in DrDr) * some of the tests were not moved, and were left as they were -- these require a GUI visualization (e.g. the animation or slideshow tests), and they don't fit in this test model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the plot tests which generate plots to save and verify the draw steps using the method introduced in 05ac34e (pull request #62)
From this migration experience, the following updates were made to the test method:
test data files are now compressed using
gzipas some of the plots generated files larger than 10Mbthe plots are updated in-place, rather than moving them to a separate folder (named "auto"), this allows for easier inspection of a file' history (the ci.yml file was updated to upload new files from all sub-directories of the "plot-test" package)
the test run in ci.yml now runs all the files, even if they don't have a test module -- some of the plot tests already used rackunit, but the tests were not in a seprate submodule, these tests are now running in Github Actions (they were already running in DrDr)
some of the tests were not moved, and were left as they were -- these require a GUI visualization (e.g. the animation or slideshow tests), and they don't fit in this test model.