Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Conversation

kwapik
Copy link
Contributor

@kwapik kwapik commented Aug 6, 2015

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a struct parameter here, let's use an interface like the other services. For an example, see here: https://github.com/rackspace/gophercloud/blob/master/openstack/networking/v2/networks/requests.go#L127

@jrperritt jrperritt changed the title Identity keystone v3 projects basic CRUD [wip] Identity keystone v3 projects basic CRUD Sep 14, 2015
@kwapik
Copy link
Contributor Author

kwapik commented Sep 15, 2015

Thanks for commenting. I'll implement changes near the end of the week.

@kwapik kwapik changed the title [wip] Identity keystone v3 projects basic CRUD Identity keystone v3 projects basic CRUD Nov 17, 2015
@kwapik
Copy link
Contributor Author

kwapik commented Nov 17, 2015

@jrperritt Sorry for the big delay, I had a lot of other work.

To sum up what I've done:

  • Applied your suggestions (changed Opts structs to interfaces, added some comments).
  • Changed Update http method from PUT to PATCH (had to add PATCH method to client).
  • Fixed tests.

@kwapik kwapik changed the title Identity keystone v3 projects basic CRUD [rfr] Identity keystone v3 projects basic CRUD Jan 20, 2016
@kwapik kwapik changed the title [rfr] Identity keystone v3 projects basic CRUD [wip] Identity keystone v3 projects basic CRUD Feb 3, 2016
@kaccardi
Copy link

@kwapik are you planning to continue to work on the PR on the new repo?

@kwapik
Copy link
Contributor Author

kwapik commented Oct 27, 2016

@kaccardi I'm afraid that I won't have time to continue this within next few months

@coveralls
Copy link

coveralls commented Nov 7, 2016

Coverage Status

Coverage increased (+0.005%) to 80.498% when pulling fb8ac8f on kwapik:identity-keystone-v3-projects into e00690e on rackspace:master.

@kwapik kwapik closed this by deleting the head repository Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants