Keystone Trust added in Extensions

[codevulture]

@jrperritt : Hi, as per discussion on: #580 i have modified the changes, Please let me know your review points and suggestions.Thanks.

[yuanying]

Seems unneeded change.

[codevulture]

go fmt result.

[coveralls]

Coverage decreased (-0.6%) to 80.455% when pulling 5e8df2e on codevulture:keystone_api_extension into 985a863 on rackspace:master.

[codevulture]

@yuanying : Indentation and line changes are resultant of go fmt command which i ran on code , as this was the standard procedure on golang for codeformating like pep in python. So i think this could be ignores or please let me know if needed to be removed.

[coveralls]

Coverage decreased (-0.3%) to 80.795% when pulling 30235bd on codevulture:keystone_api_extension into 985a863 on rackspace:master.

[yuanying]

Why did you remove password authentication? We can use this if we provide trustID.

[coveralls]

Coverage decreased (-0.5%) to 80.631% when pulling dd85cdc on codevulture:keystone_api_extension into 985a863 on rackspace:master.

[coveralls]

Coverage decreased (-0.5%) to 80.631% when pulling dc273fc on codevulture:keystone_api_extension into 985a863 on rackspace:master.

[codevulture]

@jrperritt : Please Review the changes.

[codevulture]

@jrperritt : ping.

[jrperritt]

The go fmt doesn't bother me; in fact, we should be linting and checking for that on build. What bothers me is all of the copy/paste; that shouldn't be necessary. You should convert the opts function parameter to an interface and then have the original AuthOpts and your AuthOpts (AuthOpts plus TrustID) both separately implement the method required by the interface.

[codevulture]

@jrperritt :Thanks for comments,that would mean changing code apart from extensions am i correct.. also I would like to know some more details on how implementations needs to be proceeded to be clear about what needs to be done to have these merged, I have some questions that i would like to ask as i am new to gopherhead library:

I have these files below which have the major code in them, as per your suggestions which files should be changed/removed and if possible can you specify exactly which things, that would help me a lot to implement the changes. like you specified opts but i am not sure which function you referred, please provide your guidance and feedback:

• openstack/identity/v3/extensions/auth_options.go
• openstack/identity/v3/extensions/tokens/endpoint_location.go
• openstack/identity/v3/extensions/tokens/requests.go
• openstack/identity/v3/extensions/tokens/requests_test.go
• openstack/identity/v3/extensions/tokens/results.go
• openstack/identity/v3/extensions/tokens/urls.go
• openstack/identity/v3/extensions/trust/request.go

[jrperritt]

There is no reason to have 2 open pull requests for the same feature. Discussion continued in #580