DataObject->contentLength and PaginatedIterator->shouldAppend #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't fetch contentLength from content for partial objects when the actual size of the object is 0 (zero) bytes PaginatedIterator: Collection seems to be appending elements when not necessary. Seems the 'shouldAppend' checks if the current page is divisible by the new (current +1) position. For a 'page,limit' of 100 this check returns 'TRUE' for positions like 1, 2, 4 ... IMO the check should be the other way around, so the new position is divisible by the 'limit.page'.
|
Now pushing into the 'working' branch :-) |
jamiehannaford
pushed a commit
that referenced
this pull request
Jan 10, 2014
DataObject->contentLength and PaginatedIterator->shouldAppend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataObject:
Don't fetch contentLength from content for partial objects when the actual size of the object is 0 (zero) bytes
PaginatedIterator:
Collection seems to be appending elements when not necessary. Seems the 'shouldAppend' checks if the current page is divisible by the new (current +1) position.
For a 'page,limit' of 100 this check returns 'TRUE' for positions like 1, 2, 4 ...
IMO the check should be the other way around, so the new position is divisible by the 'limit.page'.