Fixing import issue - tenant IDs can be strings #456
Conversation
| @@ -196,7 +196,7 @@ public function setTenant($tenant) | |||
| { | |||
| $identity = IdentityService::factory($this); | |||
|
|
|||
| if (is_numeric($tenant)) { | |||
| if (is_numeric($tenant) || is_string($tenant)) { | |||
There was a problem hiding this comment.
Could you update the docblock for the method to match this change, please?
There was a problem hiding this comment.
Sure - will do this and tests sometime tomorrow
There was a problem hiding this comment.
Sorry, I should've been clearer. I meant the comment that goes "If an integer is passed in..."
|
Could you please add unit tests for |
|
@ycombinator Looks like we already test string and numeric tenant IDs but the existing tests aren't really testing what we want it to test. If the argument does not match the conditional (which it was doing before), the value populates the Tenant object. If Base.php is given a scalar value, it treats it as a ID and does a GET on that resource to get more information - which is what was happening here. Ideally, what we want to test is that strings and IDs do not execute this GET request. The only way we can efficiently do this is by mocking the exact form of communication the |
|
@ycombinator and this! |
Fixing import issue - tenant IDs can be strings
Fixes #455