Adding more LB sample scripts #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the same folder as these samples scripts, there already exists a sample script for listing load balancers. It uses slightly different environment variables than the ones used by the sample scripts in this PR. Would you mind making these consistent? |
|
@ycombinator I've shifted the auth environment vars to placeholders, so I think this is ready for another review |
| $client = new Rackspace(getenv('RS_AUTH_URL'), array( | ||
| 'username' => getenv('RS_USERNAME'), | ||
| 'apiKey' => getenv('RS_API_KEY'), | ||
| )); |
There was a problem hiding this comment.
Should these be placeholders too?
jamiehannaford
force-pushed
the
lb-samples
branch
from
5f93c7b to
3c233d8
Compare
|
LGTM. Merging. |
ycombinator
added a commit
that referenced
this pull request
Nov 19, 2014
Adding more LB sample scripts
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #422