-
Notifications
You must be signed in to change notification settings - Fork 248
Reliably delete a container with its objects #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jamiehannaford
merged 13 commits into
rackspace:working
from
ycombinator:del-container-recursive
Dec 4, 2014
Merged
Reliably delete a container with its objects #481
jamiehannaford
merged 13 commits into
rackspace:working
from
ycombinator:del-container-recursive
Dec 4, 2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{ | ||
// If timeout (seconds to wait) is not specified by caller, try to | ||
// estimate it based on number of objects in container | ||
if (is_null($secondsToWait)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency (and AFAIK a slight performance gain), I always use: null === $secondsToWait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. Changing.
Apart from the timeout thing, this LGTM 👍 |
jamiehannaford
pushed a commit
that referenced
this pull request
Dec 4, 2014
Reliably delete a container with its objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a (hopefully) final attempt at providing a method to reliably delete a container along with its constituent objects. The crux of the algorithm implemented by this PR is:
409 Conflict
error (indicating that the container is not actually empty), start over with step 1.404 Not Found
error (indicating that the container is not found), we are done!Note that the existing methods to delete a container (
$container->delete()
) and to delete a container along with its objects ($container->delete($deleteObjects = false)
) are preserved so this change is backwards compatible.Additionally, another method to delete a container along with its objects is also provided (
$container->deleteWithObjects($secondsToWait = null)
). This method takes an optional timeout in seconds during which the above algorithm must complete. If this timeout is not specified, it is estimated based on the number of objects in the container.Fixes #477.