Skip to content

Using custom cipher suite for Rackspace Cloud Databases service #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 16, 2015
Merged

Using custom cipher suite for Rackspace Cloud Databases service #562

merged 13 commits into from
Mar 16, 2015

Conversation

ycombinator
Copy link
Contributor

See #560 (comment).

Fixes #560 (temporarily).

jamiehannaford
jamiehannaford reviewed Mar 16, 2015
View reviewed changes
lib/OpenCloud/Database/Service.php Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we break up the text over multiple lines? (I think this is a PSR requirement) - we'll find out soon with the linter :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. Fixing.

@ycombinator ycombinator changed the title Using TLSv1 cipher suite for Rackspace Cloud Databases service Using custom cipher suite for Rackspace Cloud Databases service Mar 16, 2015
@ycombinator ycombinator force-pushed the cloud-databases-tlsv1 branch from dcf3fa5 to d4ff6f4 Compare March 16, 2015 17:19
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.31% when pulling f7eecae on ycombinator:cloud-databases-tlsv1 into 29ba848 on rackspace:working.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.31% when pulling 6d133a3 on ycombinator:cloud-databases-tlsv1 into 29ba848 on rackspace:working.

@ycombinator
Copy link
Contributor Author

Alright @jamiehannaford this is ready for review again.

jamiehannaford
jamiehannaford reviewed Mar 16, 2015
View reviewed changes
lib/OpenCloud/Database/Service.php Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add donald's comment about what the string means as a docblock?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if I add a link to Donald's comment (https://github.com/rackspace/php-opencloud/issues/560#issuecomment-81790778) in the docblock? I'm referencing the GitHub issue in other docblocks + the critical log message as well. The advantage of this is that the conversation in the GitHub issue provides more context than we could include inline in the code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, that sounds good

@jamiehannaford
Copy link
Contributor

apart from the docblock thing, LGTM 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.31% when pulling a1eb1e0 on ycombinator:cloud-databases-tlsv1 into 29ba848 on rackspace:working.

jamiehannaford pushed a commit that referenced this pull request Mar 16, 2015
Merge pull request #562 from ycombinator/cloud-databases-tlsv1
16485f3 
Using custom cipher suite for Rackspace Cloud Databases service
@jamiehannaford jamiehannaford merged commit 16485f3 into rackspace:working Mar 16, 2015
@ycombinator ycombinator deleted the cloud-databases-tlsv1 branch March 19, 2015 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smoke tests for Databases fail with SSL error
3 participants
@ycombinator @coveralls @jamiehannaford