Skip to content

A few fixes to DNS methods' documentation #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2015
Merged

A few fixes to DNS methods' documentation #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e6b676
Fixing return type.
ycombinator Mar 22, 2015
163b035
Adding return type.
ycombinator Mar 22, 2015
1caf1d3
Adding docblock.
ycombinator Mar 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/OpenCloud/DNS/Resource/Domain.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function record($info = null)
* returns a Collection of Record objects
*
* @param array $filter query-string parameters
* @return \OpenCloud\Collection
* @return OpenCloud\DNS\Collection\DnsIterator
*/
public function recordList($filter = array())
{
Expand Down Expand Up @@ -107,6 +107,7 @@ public function subdomain($info = array())
*
* @param array $filter key/value pairs for query string parameters
* return \OpenCloud\Collection
* @return OpenCloud\DNS\Collection\DnsIterator
*/
public function subdomainList($filter = array())
{
Expand Down
11 changes: 9 additions & 2 deletions lib/OpenCloud/DNS/Service.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function domain($info = null)
* Returns a collection of domains
*
* @param array $filter key/value pairs to use as query strings
* @return \OpenCloud\Common\Collection
* @return OpenCloud\DNS\Collection\DnsIterator
*/
public function domainList($filter = array())
{
Expand All @@ -85,7 +85,7 @@ public function ptrRecord($info = null)
*
* @param \OpenCloud\Compute\Resource\Server $server the server for which to
* retrieve the PTR records
* @return \OpenCloud\Common\Collection
* @return OpenCloud\DNS\Collection\DnsIterator
*/
public function ptrRecordList(HasPtrRecordsInterface $parent)
{
Expand Down Expand Up @@ -181,6 +181,13 @@ public function limitTypes()
return $body->limitTypes;
}

/**
* List asynchronous responses' statuses.
* @see http://docs.rackspace.com/cdns/api/v1.0/cdns-devguide/content/viewing_status_all_asynch_jobs.html
*
* @param array $query Any query parameters. Optional.
* @return OpenCloud\DNS\Collection\DnsIterator
*/
public function listAsyncJobs(array $query = array())
{
$url = clone $this->getUrl();
Expand Down