-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update collection ext #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One point of clarification I think I need, a couple of suggestions:
-
Is the collection link required? It'd put some stronger language there.
-
Perhaps emphasize a bit more in the explanation that id + name are required, and explain a bit more about what they provide and how to choose them.
-
For name - is this for display? Perhaps spell that out - it's a human readable name for the collection, to be used in display of the record.
Oh, the other thing that would be really nice to have, though I'm not exactly sure how to make it, is a json schema validator. Like ideally the main validator would have a way to 'add on' an extension's json, so you could have it check your cx: or eo: fields too. But definitely not required to get this PR in. |
I realized somewhat belatedly that there's no reason it needs to be a 2-letter prefix. |
@@ -63,7 +63,7 @@ | |||
"self": { "rel":"self", "href": "http://landsat-pds.s3.amazonaws.com/L8/153/025/LC81530252014153LGN00/LC81530252014153LGN00.json"}, | |||
"alternate": { "rel":"alternate", "href": "https://landsatonaws.com/L8/153/025/LC81530252014153LGN00", "type": "html"}, | |||
"catalog": { "rel":"catalog", "href": "http://landsat-pds.s3.amazonaws.com/L8/catalog.json"}, | |||
"collection": { "rel":"collection", "href": "http://landsat-pds.s3.amazonaws.com/L8/L1T-collection.json"} | |||
"cx:collection": { "rel":"cx:ollection", "href": "http://landsat-pds.s3.amazonaws.com/L8/L1T-collection.json"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: cx:ollection
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #122 (among other things)
Updated collection extension to use a prefix in the field names it adds. Also adds a field so now there is:
cx:id
cx:name
cx:description
cc @cholmes @mojodna