-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-3645] - Seed phrase UI refinements #1115
[ABW-3645] - Seed phrase UI refinements #1115
Conversation
@@ -277,6 +278,12 @@ class RestoreMnemonicsViewModel @Inject constructor( | |||
val isMainBabylonSeedPhrase: Boolean | |||
get() = recoverableFactorSource?.factorSource?.id == mainBabylonFactorSourceId | |||
|
|||
val showAdvancedMode: Boolean | |||
get() = recoverableFactorSource?.factorSource?.hasOlympiaSeedPhraseLength ?: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is the correct way of doing it? hasOlympiaSeedPhraseLength
is 24 similar to babylon. This is not the correct way of looking if a seed phrase belongs to an account created with olympia. I think a better approach is FactorSourceCryptoParameters.supportsOlympia
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we would add same seed phrase in account recovery scan both as babylon and olympia, of size 24, you would have a seed that supports both olympia and babylon and length is 24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hasOlympiaSeedPhraseLength
checks if the word count is different than 24 and I thought this is enough to know it's not a Babylon seed phrase. But it's good to know there is a better and more reliable way to check this. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some UI related comments:
- I tried to restore a legacy olympia wallet. The textfields are hidden behind the keyboard when I write.
- Since autocompletion is removed, when I was writing I used the keyboard's auto-completion by choosing a word. Google's auto completion adds a space to the word making it invalid. Could you trim the words?
- I didn't understand what was the requirement here. Should we remove the bottom bar with the suggestions, or remove our own auto-completion, or both? Now it seems that both are removed. Is that correct?
- I am not sure the advanced mode check is the correct one. See related comment.
|
Jira Ticket
Description
This PR refines the UI mainly for the Seed Phrase entry screen:
RestoreMnemonicsScreen
RestoreMnemonicsScreen
RestoreMnemonicsScreen
How to test
Mnemonic restoring from a backup:
Mnemonic restoring for accounts recovery:
Mnemonic restoring for Olympia wallet import:
PR submission checklist