Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Version 6.4.0 - Installer - Errors #109

Closed
bovirus opened this issue Oct 30, 2023 · 7 comments
Closed

[BUG] Version 6.4.0 - Installer - Errors #109

bovirus opened this issue Oct 30, 2023 · 7 comments

Comments

@bovirus
Copy link
Contributor

bovirus commented Oct 30, 2023

@radj307

Missing info about version
License text file not use all space available
image

Installer exe file properties
(c) charcter is wrong (coding error)
Missing info about Program Version/File version
image

@radj307
Copy link
Owner

radj307 commented Oct 30, 2023

The problems with version info were fixed in fb0992a when I fixed #104

The copyright symbol was also fixed, but may still happen on some systems.
image

Can you check if the following setting is enabled on your system: Language -> Administrative language settings -> Change system locale Beta: Use Unicode UTF-8 for worldwide language support
image

@bovirus bovirus changed the title Installer - Errors Version 6.4.0 - Installer - Errors Oct 30, 2023
@bovirus
Copy link
Contributor Author

bovirus commented Oct 30, 2023

@radj307

Please take care that I used for report for installer v. 6.4.0 (released two days ago).

About version numbering (on top left and exe properties) probably seems that you didn't pass the right info about AppVersion.

@radj307 radj307 changed the title Version 6.4.0 - Installer - Errors [BUG] Version 6.4.0 - Installer - Errors Oct 30, 2023
@radj307
Copy link
Owner

radj307 commented Oct 30, 2023

(Continuing from #106)

I was able to change the license text alignment pretty easily by adding this to the [Code] section:

procedure InitializeWizard();
begin
  WizardForm.LicenseMemo.Alignment := taCenter;
end;

image

Of course, some lines are too far to the right since they are indented in the file, but this can be fixed by stripping preceding whitespace from them as well.

Related documentation:

@radj307
Copy link
Owner

radj307 commented Oct 30, 2023

With whitespace removed:
image
It still wastes some space, but at least it's actually aligned correctly.

@bovirus
Copy link
Contributor Author

bovirus commented Oct 30, 2023

@radj307

Thanks.
Please fix other problems.
LICENSE text is the last s importance.

@radj307
Copy link
Owner

radj307 commented Oct 30, 2023

All of the other problems were already solved in fb0992a and are available as build artifacts until the release of v6.5.0

If you want to download new versions before they're released, you can download the build artifact for it from the Actions tab at the top of this page.

To filter the workflow runs, click on Generate Release in the left pane, then click on the latest one that successfully completed:
image
Then scroll down to the Artifacts section at the bottom & click on build-windows to download it as an archive. Inside, you can find VolumeControl.exe & VolumeControl-Installer.exe.
image

I frequently push new tags (sometimes the same tag repeatedly) when making last minute changes before publishing a release, so there can be quite a few duplicates sometimes. Make sure you click on the most recent workflow run.
Also, build artifacts are deleted after 90 days so there is a limit to how far back you can go.

@bovirus
Copy link
Contributor Author

bovirus commented Oct 31, 2023

@radj307

Thanks.
Installer issues fixed in new beta.
Please close this ticket.

Plerase remind to fix strings issues
#110

@radj307 radj307 closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants