Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Version 6.4.0 - Strings untranslated #110

Closed
bovirus opened this issue Oct 30, 2023 · 4 comments
Closed

[BUG] Version 6.4.0 - Strings untranslated #110

bovirus opened this issue Oct 30, 2023 · 4 comments
Labels
bug Something isn't working triage Marks issues that were created with an issue template

Comments

@bovirus
Copy link
Contributor

bovirus commented Oct 30, 2023

Version

6.4.0

Windows Version

Windows 10 22H2 64bit italian

Actual Behaviour

Strings untranslated (see red boxes)

image

image

image

Expected Behaviour

Please add in language file the relative strings

Reproduction Steps

Check the options in screenshot

Log

No response

@bovirus bovirus added bug Something isn't working triage Marks issues that were created with an issue template labels Oct 30, 2023
@radj307
Copy link
Owner

radj307 commented Nov 1, 2023

Implemented localization support for enum types EFriendlyKey & ENotificationViewMode in 6e3c585 & 75e93b5, as well as the open log button.

All of the keyboard keys are included because it isn't possible to only rename specific ones. The enum names are used by default if a string is missing, so you can safely delete unnecessary keys like A-Z.

I'll start on implementing translation support for action names tomorrow, but that's going to be a lot more complex so don't expect an update on that for at least a couple days.

@radj307
Copy link
Owner

radj307 commented Nov 3, 2023

Added support for translating addon actions in 60a705c & 053f85a

Translations for the default actions are in VolumeControl.HotkeyActions/Localization, and use a slightly different naming scheme.
I created it-HotkeyActions.loc.json so you don't have to mark it as an embedded resource yourself.

@radj307
Copy link
Owner

radj307 commented Nov 3, 2023

Added support for translating default hotkey names in 75a28b7

The names will not update unless you reset the hotkeys to default after changing the language, however. There is no way around this, but hotkeys can always be renamed by the user.

@radj307
Copy link
Owner

radj307 commented Nov 3, 2023

This issue has been fixed and is now available in v6.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Marks issues that were created with an issue template
Projects
None yet
Development

No branches or pull requests

2 participants