-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: merge base.json into python.json and change snippets #454
Conversation
It seems that there's no purpose for `base.json`, there is even duplicate snippets in these 2 files, so I merged them into `python.json`. Also, deleted obsolete (e.g. python2 future and encoding) and useless (e.g. async variants because you can just type `async` and then use normal `def`) snippets, added some useful ones, made prefixes more user friendly and shortened descriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I greatly appreciate this PR (a similar refactor should happen with the LaTeX snippets, but that's a later problem).
Overall I think I'm content with these changes, have you tested these locally too @REmerald ?
Forgot to remove it in the initial commit of my pull request
@OkelleyDevelopment, for the most part they do, but there are 2 problems with some neovim setups. For some reason
and inserted text is
Similar situation the nested placeholder like And secondly, for some reason after typing These 2 issues seem to be related to snippets in almost all languages, not just python, so I think, we can merge this pr and later figure out if it's our issue or not. |
Yeah that seems to be a problem out of scope for this PR, so I'll merge these. FWIW in my local setup (a little different from my last config update), was able to handle this snippet:
|
Feel free to raise an issue with whatever you've researched (even if it's just a copy-paste from the above text) @REmerald. |
It seems that there's no purpose for
base.json
, there is even duplicate snippets in these 2 files.So I merged them into
python.json
.Also, deleted obsolete (e.g. python2 future and encoding) and useless (e.g. async variants because you can just type
async
and then use normaldef
) snippets, added some useful ones, made prefixes more user friendly and shortened descriptions.