polymorphic has_many associations seem to be broken

[jonah-williams]

When I define a polymorphic has_many association I expect the serializer to produce an array of hashes each of which looks like the output of a polymorphic has_one association. Instead the polymorphic: true option seems to have no effect.

Issue #13 seems to suggest that this should work. However none of the polymorphic tests use has_many and Association::HasMany does not consider the polymorphic option as Association::HasOne does. Am I missing something?

See https://github.com/carbonfive/active_model_serializers/tree/has_many_support_polymorphic_associations for example failing tests.

I'll see if I can provide a fix in a pull request.

cc @AlexMouton

[lukaszx0]

That's correct. Polymorphic associations wasn't supported thanks a lot for the pull request - great work! However @spastorino did big rewrite recently and I think you'll need to rework your PR to merge it as a lot of core stuff have changed.

Having that said, polymorphic assocs are on AMS todo list and it would be great if you could provide new PR adjusted to master. Thank you! <3

[spastorino]

polymorphic associations are not in master anymore. We would need to rewrite that for master too. I think we can close this for now. Thanks a lot for your help. If you want you can go ahead and try to re-write polymorphic assocs for master.

[jonah-williams]

I agree, this branch is no longer relevant. I'll try to put together a more up to date implementation.

[spastorino]

@jonah-carbonfive thanks a lot!, if you're willing to help on AMS please ping me over twitter :)

[cmrd-senya]

Sorry for the bringing up an old topic, but I didn't want to create a new issue since I didn't know if it is a bug or a feature. has_many/polymorphic doesn't seems not to work on AMS 0.10.6 for me right now. I created a question on stackoverflow (as suggested by the readme) describing my case, but for the case it's an issue that needs some care from developers I leave this note here.