Refactor Association into Field like everything else #1897
Conversation
|
@bf4, thanks for your PR! By analyzing the annotation information on this pull request, we identified @beauby, @ehsanyousefi and @groyoh to be potential reviewers |
|
@NullVoxPopuli Where do you think a regression test for something like #1857 (comment) should go? |
bf4
force-pushed
the
make_association_a_field
branch
2 times, most recently
from
791ae53 to
032b078
Compare
|
@bf4, maybe in It looks like both test files don't do anything with polymorphic belongs_to |
| # Association.new(:comments, { serializer: CommentSummarySerializer }) | ||
| # | ||
| Association = Struct.new(:name, :serializer, :options, :links, :meta) do | ||
| class Association < Field |
|
I'm a fan overall. |
bf4
force-pushed
the
make_association_a_field
branch
from
032b078 to
6956c47
Compare
|
@NullVoxPopuli rebased I"m not sure what your comment is referring to. (The file is |
you asked:
? or did you mean something else? |
|
Looks like the inflection testing in test/adapter/json_api/type_test.rb is really testing |
That should probably move to the test file for resource_identifier then. |
|
@NullVoxPopuli oh, github presentation of doc led me not to see your comment as a response to mine 🤦 |
|
I'm not planning any more changes for this PR. Anything you suggest? |
|
Nope, this is a good chunk of good changes :-) I like when things get less convoluted :-) I'll merge when CI passes |
3 participants
Intended to simplify work in #1857