Skip to content

Conversation

phoet
Copy link
Contributor

@phoet phoet commented Aug 13, 2013

off topic: please deactivate the WIKI if there is no content in it

off topic: please deactivate the WIKI if there is no content in it
@rafaelfranca
Copy link

Off topic: Done

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 56eaa61 on phoet:patch-1 into 8ac4bf9 on rails-api:master.

@phoet
Copy link
Contributor Author

phoet commented Aug 13, 2013

👍 THX!

@steveklabnik
Copy link
Contributor

... do we really need this? Is it a good idea to talk about testing without even showing a test?

I think I'd rather either have nothing about this at all, or a full test case. What do you think?

@rafaelfranca
Copy link

I agree that we don't need this. If you want to test any object you can to call .new on the class.

@phoet
Copy link
Contributor Author

phoet commented Aug 13, 2013

@steveklabnik @rafaelfranca you are missing the point. there is NO example in the readme, that you can actually use .new with serializers.

@phoet
Copy link
Contributor Author

phoet commented Aug 13, 2013

:trollface: that's not the readme

as @steveklabnik mentioned, it would be good to have something about testing in the readme. i did not provide an example because my RSpec code would be to specific for that.

@rafaelfranca
Copy link

Well, it is not the README but it is still part of the documentation of the project.

Really I don't think we need something to tell people that we can call .new in a class, but if want to write a section about testing go it will be great.

@phoet
Copy link
Contributor Author

phoet commented Aug 13, 2013

i will provide an example for RSpec and MiniTest, i hope that's enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants