Skip to content

Correctly catch and re-raise HTTPX PoolTimeoutErrors #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
+9 −0
Merged

Correctly catch and re-raise HTTPX PoolTimeoutErrors #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/action_push_native/service/network_error_handling.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ module ActionPushNative::Service::NetworkErrorHandling

def handle_network_error(error)
case error
when HTTPX::PoolTimeoutError
raise error
when Errno::ETIMEDOUT, HTTPX::TimeoutError
raise ActionPushNative::TimeoutError, error.message
when Errno::ECONNRESET, Errno::ECONNABORTED, Errno::ECONNREFUSED, Errno::EHOSTUNREACH,
Expand Down
7 changes: 7 additions & 0 deletions test/lib/action_push_native/service/apns_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,13 @@ class ApnsTest < ActiveSupport::TestCase
assert_raises ActionPushNative::ConnectionError do
@apns.push(@notification)
end

stub_request(:post, "https://api.push.apple.com/3/device/123").
to_raise(HTTPX::PoolTimeoutError.new(5, "Timed out after 5 seconds while waiting for a connection"))

assert_raises HTTPX::PoolTimeoutError do
@apns.push(@notification)
end
end

test "push apns payload can be overridden" do
Expand Down